yiguolei commented on code in PR #51199: URL: https://github.com/apache/doris/pull/51199#discussion_r2105674674
########## be/test/common/config_test.cpp: ########## @@ -145,6 +146,22 @@ TEST_F(ConfigTest, UpdateConfigs) { EXPECT_TRUE(s.to_string().find("'cfg_std_string' is not support to modify") != std::string::npos); EXPECT_EQ(cfg_std_string, "doris_config_test_string"); + + // replace + setenv("TEST_CONF_ENV", "test_dir1", true); + s = config::set_config("cfg_conf_path", "${TEST_CONF_ENV}/test"); + EXPECT_TRUE(s.ok()); + EXPECT_EQ(cfg_conf_path, "test_dir1/test"); + + setenv("TEST_CONF_ENV", "test_dir2", true); + s = config::set_config("cfg_conf_path", "$TEST_CONF_ENV/test"); + EXPECT_TRUE(s.ok()); + EXPECT_EQ(cfg_conf_path, "test_dir2/test"); Review Comment: 可以帮忙review 下这个文档 https://doris.apache.org/zh-CN/docs/admin-manual/config/be-config -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org