morrySnow commented on code in PR #51163:
URL: https://github.com/apache/doris/pull/51163#discussion_r2103934094
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/scalar/Sha2.java:
##########
@@ -41,13 +44,31 @@ public class Sha2 extends ScalarFunction
FunctionSignature.ret(VarcharType.SYSTEM_DEFAULT).args(VarcharType.SYSTEM_DEFAULT,
IntegerType.INSTANCE),
FunctionSignature.ret(VarcharType.SYSTEM_DEFAULT).args(StringType.INSTANCE,
IntegerType.INSTANCE));
+ private static final List<Integer> validDigest = Lists.newArrayList(224,
256, 384, 512);
Review Comment:
static variable's name should use UPPER_CASE name format
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
