yiguolei commented on code in PR #50935:
URL: https://github.com/apache/doris/pull/50935#discussion_r2099556251
##########
be/src/exec/olap_common.h:
##########
@@ -91,7 +91,8 @@ std::string cast_to_string(T value, int scale) {
template <PrimitiveType primitive_type>
class ColumnValueRange {
public:
- using CppType = typename PrimitiveTypeTraits<primitive_type>::CppType;
+ using CppType = std::conditional_t<primitive_type == TYPE_HLL, StringRef,
Review Comment:
这个有必要处理HLL 吗？ 是不是所有的column value range 都是简单类型？
##########
be/src/exec/olap_common.h:
##########
@@ -1014,7 +1015,8 @@ template <PrimitiveType primitive_type>
Status OlapScanKeys::extend_scan_key(ColumnValueRange<primitive_type>& range,
int32_t max_scan_key_num, bool*
exact_value, bool* eos,
bool* should_break) {
- using CppType = typename PrimitiveTypeTraits<primitive_type>::CppType;
+ using CppType = std::conditional_t<primitive_type == TYPE_HLL, StringRef,
Review Comment:
还有这里
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
