HappenLee commented on code in PR #50769:
URL: https://github.com/apache/doris/pull/50769#discussion_r2097468344
##########
be/src/util/arrow/row_batch.cpp:
##########
@@ -47,9 +48,13 @@
namespace doris {
-Status convert_to_arrow_type(const vectorized::DataTypePtr& type,
+Status convert_to_arrow_type(const vectorized::DataTypePtr& origin_type,
std::shared_ptr<arrow::DataType>* result,
const std::string& timezone) {
+ auto type = origin_type;
+ if (const auto* typed = typeid_cast<const
vectorized::DataTypeAggState*>(type.get()); typed) {
+ type = typed->get_serialized_type();
+ }
switch (type->get_primitive_type()) {
Review Comment:
why union use `get_serialized_type` if not AggState ? return this or self ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
