HappenLee commented on code in PR #48720:
URL: https://github.com/apache/doris/pull/48720#discussion_r2097166514
##########
be/src/vec/sink/tablet_sink_hash_partitioner.h:
##########
@@ -46,10 +46,14 @@ class TabletSinkHashPartitioner final : public
PartitionerBase {
Status open(RuntimeState* state) override;
- Status do_partitioning(RuntimeState* state, Block* block, bool eos,
- bool* already_sent) const override;
+ Status do_partitioning(RuntimeState* state, Block* block) const override;
+ Status try_cut_in_line(Block& prior_block) const override;
+ void finish_cut_in_line() const override;
+ void mark_last_block() const override { _row_distribution._deal_batched =
true; }
ChannelField get_channel_ids() const override;
+ std::vector<bool> get_skipped(int size) const override { return _skipped; }
Review Comment:
why return reference?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
