CalvinKirs commented on code in PR #50849:
URL: https://github.com/apache/doris/pull/50849#discussion_r2096756233


##########
fe/fe-core/src/main/java/org/apache/doris/persist/gson/GsonUtils.java:
##########
@@ -581,6 +581,24 @@ public class GsonUtils {
             .registerSubtype(S3FileSystem.class, 
S3FileSystem.class.getSimpleName())
             .registerSubtype(AzureFileSystem.class, 
AzureFileSystem.class.getSimpleName());
 
+    private static 
RuntimeTypeAdapterFactory<org.apache.doris.fsv2.PersistentFileSystem>

Review Comment:
   If we create a repository, it will fail after a restart—because the 
repository gets instantiated during metadata replay. Unless we allow 
serialization to skip failed entries, which would be a bigger change...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to