morrySnow commented on code in PR #11035:
URL: https://github.com/apache/doris/pull/11035#discussion_r932117136
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/parser/LogicalPlanBuilder.java:
##########
@@ -206,11 +211,33 @@ public LogicalPlan
visitRegularQuerySpecification(RegularQuerySpecificationConte
/**
* Create an aliased table reference. This is typically used in FROM
clauses.
*/
+ private LogicalPlan withTableAlias(LogicalPlan plan, TableAliasContext
ctx) {
Review Comment:
add a Developing annotation
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/memo/GroupExpression.java:
##########
@@ -168,6 +169,12 @@ public boolean equals(Object o) {
return false;
}
GroupExpression that = (GroupExpression) o;
+ // if the plan is LogicalRelation, this == that should be true,
+ // when if one relation appear in plan more than once,
+ // we cannot distinguish them throw equals function, since equals
function cannot use output info.
+ if (plan instanceof LogicalRelation) {
Review Comment:
should also add physical relation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
