zhannngchen commented on code in PR #51001:
URL: https://github.com/apache/doris/pull/51001#discussion_r2094795164


##########
be/src/olap/rowset/segment_v2/segment_writer.cpp:
##########
@@ -811,7 +813,16 @@ Status SegmentWriter::append_block(const 
vectorized::Block* block, size_t row_po
         }
         
RETURN_IF_ERROR(_column_writers[id]->append(converted_result.second->get_nullmap(),
                                                     
converted_result.second->get_data(), num_rows));
+        for (size_t row_id = 0; row_id < block->rows(); ++row_id) {
+            const auto& stringRef = 
block->get_by_position(cid).column->get_data_at(row_id);
+            total_data_size += stringRef.size;
+            column_data_size += stringRef.size;
+        }
+        _footer.mutable_columns(id)->set_total_data_size(column_data_size);

Review Comment:
   it's reset each time when `append_block()`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to