yiguolei commented on code in PR #50996: URL: https://github.com/apache/doris/pull/50996#discussion_r2094786101
########## be/src/vec/exec/scan/olap_scanner.h: ########## @@ -64,7 +64,7 @@ class OlapScanner : public Scanner { int64_t version; TabletReader::ReadSource read_source; int64_t limit; - bool aggregation; + bool is_pre_aggregation; Review Comment: add some comment to explain the meaning of this parameter. And you could provide some use cases so that other developer could get the meaning more clearly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org