Gabriel39 commented on code in PR #11277: URL: https://github.com/apache/doris/pull/11277#discussion_r931748931
########## fe/fe-core/src/main/java/org/apache/doris/catalog/FunctionSet.java: ########## @@ -1388,6 +1388,19 @@ private void initAggregateBuiltins() { "", "", true, false, true, true)); + addBuiltin(AggregateFunction.createBuiltin(FunctionSet.WINDOW_FUNNEL, Review Comment: Only `create_aggregate_function_window_funnel` is registered in function factory as a function creator. When we pass a window argument with date type, a function implement `AggregateFunctionWindowFunnel<DateV2Value<DateV2ValueType>, UInt32>` will be returned. So no extra things is registered -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org