BiteTheDDDDt commented on code in PR #50720: URL: https://github.com/apache/doris/pull/50720#discussion_r2083775685
########## be/src/pipeline/exec/join/process_hash_table_probe_impl.h: ########## @@ -521,6 +532,75 @@ Status ProcessHashTableProbe<JoinOpType>::do_mark_join_conjuncts(vectorized::Blo return finalize_block_with_filter(output_block, result_column_id, result_column_id); } +template <int JoinOpType> +Status ProcessHashTableProbe<JoinOpType>::do_right_half_mark_join_conjuncts( + vectorized::Block* output_block) { + DCHECK(JoinOpType == TJoinOp::RIGHT_SEMI_JOIN || JoinOpType == TJoinOp::RIGHT_ANTI_JOIN) Review Comment: return error status to replace dcheck -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org