dataroaring commented on code in PR #50688:
URL: https://github.com/apache/doris/pull/50688#discussion_r2078849634


##########
be/src/olap/wal/wal_table.cpp:
##########
@@ -89,12 +89,17 @@ Status WalTable::_relay_wal_one_by_one() {
         wal_info->add_retry_num();
         auto st = _replay_wal_internal(wal_info->get_wal_path());
         auto msg = st.msg();
+        std::filesystem::path file_path(wal_info->get_wal_path());
+        if (!std::filesystem::exists(file_path)) {
+            LOG(WARNING) << "wal file=" << wal_info->get_wal_path() << " does 
not exist";
+        }
+        auto file_size = std::filesystem::file_size(file_path);

Review Comment:
   if the file does not exist, file_size maybe throw a exception, and we should 
catch it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to