yiguolei commented on code in PR #11131:
URL: https://github.com/apache/doris/pull/11131#discussion_r930661945


##########
be/src/olap/rowset/rowset_meta.h:
##########
@@ -324,24 +337,38 @@ class RowsetMeta {
 
     int64_t newest_write_timestamp() const { return 
_rowset_meta_pb.newest_write_timestamp(); }
     void set_tablet_schema(const TabletSchema* tablet_schema) {

Review Comment:
   Do not pass in raw ptr here, could pass TabletSchemaSPtr if possible.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to