Re: [PR] [opt](memtracker) Optimize `PODArray` memory tracking accuracy [doris]

[via GitHub]

xinyiZzz commented on code in PR #50549:
URL: https://github.com/apache/doris/pull/50549#discussion_r2077139836


##########
be/src/vec/common/pod_array.h:
##########
@@ -143,6 +146,32 @@ class PODArrayBase : private boost::noncopyable,
         return byte_size(num_elements) + pad_right + pad_left;
     }
 
+    // `tracking_and_check_memory` is called after alloc memory.
+    inline void tracking_and_check_memory(int64_t size) {
+        CONSUME_THREAD_MEM_TRACKER(size);
+        std::string err_msg;

Review Comment:
   不行，if 会用到这个 string
   
![image](https://github.com/user-attachments/assets/57dfb49d-9fa4-4b95-b569-f37d234f6546)
   我想想有没有更好的写法



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org