gavinchou commented on code in PR #45287:
URL: https://github.com/apache/doris/pull/45287#discussion_r2066897413
##########
be/src/util/slice.h:
##########
@@ -273,6 +273,13 @@ struct Slice {
}
return buf;
}
+
+ // X is (maybe) a truncated prefix of string X'
+ // Y is (maybe) a truncated prefix of string Y'
+ // return true only if we can determine that X' is strictly less than Y'
+ // based on these maybe truncated prefixes
+ static bool lhs_is_strictly_less_than_rhs(Slice X, bool X_is_truncated,
Slice Y,
Review Comment:
the comment is confusing and the parameters are not explained well
what is X and what is x_is_truncated.
it is better to show some examples to describe the behavior of this function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
