gavinchou commented on code in PR #50535:
URL: https://github.com/apache/doris/pull/50535#discussion_r2065655504
##########
gensrc/proto/cloud.proto:
##########
@@ -1108,6 +1108,8 @@ message AlterClusterRequest {
optional Operation op = 4;
// for SQL mode rename cluster, rename to cluster name eq instance empty
cluster name, need drop empty cluster
optional bool replace_if_existing_empty_target_cluster = 5;
+ // if true, check if drop_cluster op on sql type cluster is in safe time
+ optional bool safe_drop_on_sql_cluster = 6 [default = true];
Review Comment:
pls do not use default value, or there will be too many assumptions to be
considered in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
