dataroaring commented on code in PR #50489:
URL: https://github.com/apache/doris/pull/50489#discussion_r2062863875
##########
fe/fe-core/src/main/java/org/apache/doris/catalog/ListPartitionInfo.java:
##########
@@ -207,21 +207,27 @@ public String toSql(OlapTable table, List<Long>
partitionId) {
String partitionName = partition.getName();
List<PartitionKey> partitionKeys = entry.getValue().getItems();
- sb.append("PARTITION ").append(partitionName).append(" VALUES IN
");
- sb.append("(");
+ sb.append("PARTITION ").append(partitionName);
+ StringBuilder partitionKeysBuilder = new StringBuilder();
int idxInternal = 0;
for (PartitionKey partitionKey : partitionKeys) {
String partitionKeyStr = partitionKey.toSql();
- if (!isMultiColumnPartition) {
+ if (!isMultiColumnPartition && !partitionKeyStr.isEmpty()) {
partitionKeyStr = partitionKeyStr.substring(1,
partitionKeyStr.length() - 1);
}
- sb.append(partitionKeyStr);
+ partitionKeysBuilder.append(partitionKeyStr);
if (partitionKeys.size() > 1 && idxInternal !=
partitionKeys.size() - 1) {
- sb.append(",");
+ partitionKeysBuilder.append(",");
}
idxInternal++;
}
- sb.append(")");
+
+ // length == 0 means it is a default partition
+ if (partitionKeysBuilder.length() > 0) {
+ sb.append(" VALUES IN ").append("(");
+ sb.append(partitionKeysBuilder.toString());
+ sb.append(")");
Review Comment:
Please add regression test.
##########
fe/fe-core/src/main/java/org/apache/doris/catalog/ListPartitionInfo.java:
##########
@@ -207,21 +207,27 @@ public String toSql(OlapTable table, List<Long>
partitionId) {
String partitionName = partition.getName();
List<PartitionKey> partitionKeys = entry.getValue().getItems();
- sb.append("PARTITION ").append(partitionName).append(" VALUES IN
");
- sb.append("(");
+ sb.append("PARTITION ").append(partitionName);
+ StringBuilder partitionKeysBuilder = new StringBuilder();
int idxInternal = 0;
for (PartitionKey partitionKey : partitionKeys) {
String partitionKeyStr = partitionKey.toSql();
- if (!isMultiColumnPartition) {
+ if (!isMultiColumnPartition && !partitionKeyStr.isEmpty()) {
partitionKeyStr = partitionKeyStr.substring(1,
partitionKeyStr.length() - 1);
}
- sb.append(partitionKeyStr);
+ partitionKeysBuilder.append(partitionKeyStr);
if (partitionKeys.size() > 1 && idxInternal !=
partitionKeys.size() - 1) {
- sb.append(",");
+ partitionKeysBuilder.append(",");
}
idxInternal++;
}
- sb.append(")");
+
+ // length == 0 means it is a default partition
+ if (partitionKeysBuilder.length() > 0) {
+ sb.append(" VALUES IN ").append("(");
+ sb.append(partitionKeysBuilder.toString());
+ sb.append(")");
Review Comment:
Please add regression test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
