zhengshiJ commented on code in PR #11129: URL: https://github.com/apache/doris/pull/11129#discussion_r928687432
########## fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/Exists.java: ########## @@ -0,0 +1,87 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package org.apache.doris.nereids.trees.expressions; + +import org.apache.doris.nereids.exceptions.UnboundException; +import org.apache.doris.nereids.trees.expressions.visitor.ExpressionVisitor; +import org.apache.doris.nereids.trees.plans.logical.LogicalPlan; +import org.apache.doris.nereids.types.BooleanType; +import org.apache.doris.nereids.types.DataType; + +import com.google.common.base.Preconditions; + +import java.util.List; +import java.util.Objects; + +/** + * Exists subquery expression. + */ +public class Exists extends SubqueryExpr { + + public Exists(LogicalPlan subquery) { + super(Objects.requireNonNull(subquery, "subquery can not be null")); + } + + @Override + public DataType getDataType() throws UnboundException { + return BooleanType.INSTANCE; + } + + @Override + public boolean nullable() throws UnboundException { Review Comment: done ########## fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/SubqueryExpr.java: ########## @@ -0,0 +1,128 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package org.apache.doris.nereids.trees.expressions; + +import org.apache.doris.nereids.exceptions.UnboundException; +import org.apache.doris.nereids.trees.expressions.visitor.ExpressionVisitor; +import org.apache.doris.nereids.trees.plans.logical.LogicalPlan; +import org.apache.doris.nereids.types.BooleanType; +import org.apache.doris.nereids.types.DataType; + +import com.google.common.base.Preconditions; + +import java.util.List; +import java.util.Objects; + +/** + * Subquery Expression. + */ +public class SubqueryExpr extends Expression { + protected LogicalPlan subquery; + + public SubqueryExpr(LogicalPlan subquery) { + this.subquery = Objects.requireNonNull(subquery, "subquery can not be null"); + } + + @Override + public DataType getDataType() throws UnboundException { + // TODO: + // Returns the data type of the row on a single line + // For multiple lines, struct type is returned, in the form of splicing, + // but it seems that struct type is not currently supported + return BooleanType.INSTANCE; + } + + @Override + public boolean nullable() throws UnboundException { + // TODO: + // Any child is nullable, the whole is nullable + return false; Review Comment: done ########## fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/visitor/ExpressionVisitor.java: ########## @@ -205,6 +208,18 @@ public R visitCaseWhen(CaseWhen caseWhen, C context) { return visit(caseWhen, context); } + public R visitInSubquery(InSubquery in, C context) { + return visit(in, context); Review Comment: done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
