yiguolei commented on code in PR #49884: URL: https://github.com/apache/doris/pull/49884#discussion_r2061917045
########## fe/fe-core/src/main/java/org/apache/doris/resource/workloadgroup/WorkloadGroupMgr.java: ########## @@ -670,4 +605,92 @@ public ProcResult fetchResult(UserIdentity currentUserIdentity) { return result; } } + + + public List<WorkloadGroup> getOldWorkloadGroup() { + List<WorkloadGroup> oldWgList = Lists.newArrayList(); + readLock(); + try { + for (Map.Entry<Pair<String, String>, WorkloadGroup> entry : nameToWorkloadGroup.entrySet()) { + if (EMPTY_COMPUTE_GROUP.equals(entry.getKey().first)) { + oldWgList.add(entry.getValue()); + } + } + } finally { + readUnlock(); + } + return oldWgList; + } + + public void tryCreateNormalWorkloadGroup() { + writeLock(); + try { + LOG.info("[init_wg] before create normal wg, id map: {}, name map: {}", idToWorkloadGroup, + nameToWorkloadGroup); + if (idToWorkloadGroup.isEmpty()) { + String defaultCgName = Config.isCloudMode() ? Tag.VALUE_DEFAULT_COMPUTE_GROUP_NAME + : Tag.VALUE_DEFAULT_TAG; + Map<String, String> properties = Maps.newHashMap(); + properties.put(WorkloadGroup.ENABLE_MEMORY_OVERCOMMIT, "true"); + properties.put(WorkloadGroup.COMPUTE_GROUP, defaultCgName); + WorkloadGroup defaultWg = new WorkloadGroup(Env.getCurrentEnv().getNextId(), DEFAULT_GROUP_NAME, + properties); + idToWorkloadGroup.put(defaultWg.getId(), defaultWg); Review Comment: 这里需要检查一下,之前 default compute group 下的normal 是否已经存在了。如果存在了,就别改了。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org