yiguolei commented on code in PR #50292:
URL: https://github.com/apache/doris/pull/50292#discussion_r2057763828
##########
be/src/olap/memtable_flush_executor.cpp:
##########
@@ -190,7 +190,10 @@ Status FlushToken::_do_flush_memtable(MemTable* memtable,
int32_t segment_id, in
/// FIXME: support UT
#if defined(USE_MEM_TRACKER) && !defined(BE_TEST)
auto reserve_size = memtable->get_flush_reserve_memory_size();
- RETURN_IF_ERROR(_try_reserve_memory(memtable->resource_ctx(),
reserve_size));
+ if
(memtable->resource_ctx()->task_controller()->is_enable_reserve_memory() &&
+ reserve_size > 0) {
+ RETURN_IF_ERROR(_try_reserve_memory(memtable->resource_ctx(),
reserve_size));
Review Comment:
这个try reserve 里面似乎是死循环，有可能不对，得加上超时的逻辑
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
