ChenMiaoi commented on code in PR #50151:
URL: https://github.com/apache/doris/pull/50151#discussion_r2055861103
##########
be/src/vec/functions/function_jsonb.cpp:
##########
@@ -1919,38 +1978,244 @@ class FunctionJsonSearch : public IFunction {
};
}
- // search_str
ColumnPtr col_search;
- bool search_is_const = false;
- std::tie(col_search, search_is_const) =
- unpack_if_const(block.get_by_position(arguments[2]).column);
+ *search_is_const = false;
- const ColumnString* col_search_string =
- check_and_get_column<ColumnString>(col_search.get());
- if (auto* nullable =
check_and_get_column<ColumnNullable>(col_search.get())) {
- col_search_string =
-
check_and_get_column<ColumnString>(*nullable->get_nested_column_ptr());
- }
- if (!col_search_string) {
- return Status::RuntimeError("Illegal arg pattern {} should be
ColumnString",
- col_search->get_name());
- }
- if (search_is_const) {
- CheckNullFun search_null_check = always_not_null;
+ RETURN_IF_ERROR(parse_column_args(context, block, arguments, 2,
search_is_const, col_search,
+ col_search_string));
+
+ if (*search_is_const) {
+ search_null_check = always_not_null;
if (col_search->is_null_at(0)) {
search_null_check = always_null;
}
- RETURN_IF_ERROR(execute_vector<true>(
+ } else {
+ search_null_check = [col_search](size_t i) { return
col_search->is_null_at(i); };
+ }
+
+ return Status::OK();
+ }
+};
+
+template <typename Impl>
+class FunctionJsonSearch : public IFunction {
+public:
+ static constexpr auto name = "json_search";
+ static FunctionPtr create() { return
std::make_shared<FunctionJsonSearch<Impl>>(); }
+
+ String get_name() const override { return name; }
+ bool is_variadic() const override { return true; }
+ DataTypes get_variadic_argument_types_impl() const override {
+ return Impl::get_variadic_argument_types();
+ }
+ size_t get_number_of_arguments() const override {
+ return get_variadic_argument_types_impl().size();
+ }
+ DataTypePtr get_return_type_impl(const DataTypes& arguments) const
override {
+ return make_nullable(std::make_shared<DataTypeJsonb>());
+ }
+ bool use_default_implementation_for_nulls() const override { return false;
}
+
+ Status open(FunctionContext* context, FunctionContext::FunctionStateScope
scope) override {
+ if (scope != FunctionContext::THREAD_LOCAL) {
+ return Status::OK();
+ }
+ if (context->is_col_constant(2)) {
+ std::shared_ptr<LikeState> state = std::make_shared<LikeState>();
+ state->is_like_pattern = true;
+ // The default is \ if the escape_char argument is missing or NULL.
+ // Otherwise, escape_char must be a constant that is empty or one
character.
+ state->search_state.escape_char = '\\';
+ const auto pattern_col = context->get_constant_col(2)->column_ptr;
+ const auto& pattern = pattern_col->get_data_at(0);
+ RETURN_IF_ERROR(
+ FunctionLike::construct_like_const_state(context, pattern,
state, false));
+ context->set_function_state(scope, state);
+ }
+ return Status::OK();
+ }
+
+ Status execute_impl(FunctionContext* context, Block& block, const
ColumnNumbers& arguments,
+ uint32_t result, size_t input_rows_count) const
override {
+ return Impl::execute_impl(context, block, arguments, result,
input_rows_count);
+ }
+};
+
+#define JSON_SEARCH_NORMAL_PREPARE()
\
+ JsonSearchUtil::CheckNullFun json_null_check =
JsonSearchUtil::always_not_null; \
+ JsonSearchUtil::GetJsonStringRefFun get_json_fun;
\
+
\
+ JsonSearchUtil::CheckNullFun one_null_check =
JsonSearchUtil::always_not_null; \
+ JsonSearchUtil::OneFun one_check = JsonSearchUtil::always_one;
\
+
\
+ JsonSearchUtil::CheckNullFun search_null_check =
JsonSearchUtil::always_not_null; \
+ const ColumnString* col_search_string;
\
+ bool search_is_const = false;
\
+
\
+ RETURN_IF_ERROR(JsonSearchUtil::execute_prepare(
\
+ context, block, arguments, json_null_check, get_json_fun,
one_null_check, one_check, \
+ search_null_check, col_search_string, &search_is_const))
+
+struct JsonSearchNormal {
+ static DataTypes get_variadic_argument_types() {
+ return {
+ std::make_shared<DataTypeString>(),
+ std::make_shared<DataTypeString>(),
+ std::make_shared<DataTypeString>(),
+ };
+ }
+
+ static Status execute_impl(FunctionContext* context, Block& block,
+ const ColumnNumbers& arguments, uint32_t result,
+ size_t input_rows_count) {
+ if (arguments.size() != 3) {
+ return Status::InvalidArgument("wrong arguments for function
json_search");
+ }
+
+ JSON_SEARCH_NORMAL_PREPARE();
+
+ if (search_is_const) {
+ RETURN_IF_ERROR(JsonSearchUtil::execute_vector<true>(
block, input_rows_count, json_null_check, get_json_fun,
one_null_check,
one_check, search_null_check, col_search_string, context,
result));
} else {
- CheckNullFun search_null_check = [col_search](size_t i) {
- return col_search->is_null_at(i);
- };
- RETURN_IF_ERROR(execute_vector<false>(
+ RETURN_IF_ERROR(JsonSearchUtil::execute_vector<false>(
block, input_rows_count, json_null_check, get_json_fun,
one_null_check,
one_check, search_null_check, col_search_string, context,
result));
}
+
+ return Status::OK();
+ }
+};
+
+#define JSON_SEARCH_EXTRA_PREPARE(arg_name, index, null_check_fn, get_type,
get_fn) \
+ JsonSearchUtil::CheckNullFun arg_name##_null_check =
JsonSearchUtil::always_null; \
+ get_type get_##arg_name##_string;
\
+
\
+ ColumnPtr col_##arg_name;
\
+ bool arg_name##_is_const = false;
\
+ const ColumnString* col_##arg_name##_string;
\
+
\
+ RETURN_IF_ERROR(JsonSearchUtil::parse_column_args(context, block,
arguments, index, \
+ &arg_name##_is_const,
col_##arg_name, \
+
col_##arg_name##_string)); \
+
\
+ if (arg_name##_is_const) {
\
+ if (col_##arg_name->is_null_at(0)) {
\
+ arg_name##_null_check = JsonSearchUtil::always_null;
\
+ }
\
+ } else {
\
+ arg_name##_null_check = null_check_fn;
\
+ get_##arg_name##_string = get_fn;
\
+ }
+
+#define JSON_SEARCH_EXTRA_PREPARE_ESCAPE()
\
+ JsonSearchUtil::CheckNullFun escape_null_check =
JsonSearchUtil::always_null; \
+ JsonSearchUtil::GetJsonEscapeFun get_escape_string;
\
+
\
+ ColumnPtr col_escape;
\
+ bool escape_is_const = false;
\
+ const ColumnString* col_escape_string;
\
+
\
+ RETURN_IF_ERROR(JsonSearchUtil::parse_column_args(
\
+ context, block, arguments, 3, &escape_is_const, col_escape,
col_escape_string)); \
+
\
+ if (!escape_is_const) {
\
+ /* return Status::RuntimeError("JsonSearch escape_char CANNOT be
non-constant column");*/ \
Review Comment:
done, because the unit test not use `Consted {TypeIndex::String}`.
##########
be/src/vec/functions/function_jsonb.cpp:
##########
@@ -1919,38 +1978,244 @@ class FunctionJsonSearch : public IFunction {
};
}
- // search_str
ColumnPtr col_search;
- bool search_is_const = false;
- std::tie(col_search, search_is_const) =
- unpack_if_const(block.get_by_position(arguments[2]).column);
+ *search_is_const = false;
- const ColumnString* col_search_string =
- check_and_get_column<ColumnString>(col_search.get());
- if (auto* nullable =
check_and_get_column<ColumnNullable>(col_search.get())) {
- col_search_string =
-
check_and_get_column<ColumnString>(*nullable->get_nested_column_ptr());
- }
- if (!col_search_string) {
- return Status::RuntimeError("Illegal arg pattern {} should be
ColumnString",
- col_search->get_name());
- }
- if (search_is_const) {
- CheckNullFun search_null_check = always_not_null;
+ RETURN_IF_ERROR(parse_column_args(context, block, arguments, 2,
search_is_const, col_search,
+ col_search_string));
+
+ if (*search_is_const) {
+ search_null_check = always_not_null;
if (col_search->is_null_at(0)) {
search_null_check = always_null;
}
- RETURN_IF_ERROR(execute_vector<true>(
+ } else {
+ search_null_check = [col_search](size_t i) { return
col_search->is_null_at(i); };
+ }
+
+ return Status::OK();
+ }
+};
+
+template <typename Impl>
+class FunctionJsonSearch : public IFunction {
+public:
+ static constexpr auto name = "json_search";
+ static FunctionPtr create() { return
std::make_shared<FunctionJsonSearch<Impl>>(); }
+
+ String get_name() const override { return name; }
+ bool is_variadic() const override { return true; }
+ DataTypes get_variadic_argument_types_impl() const override {
+ return Impl::get_variadic_argument_types();
+ }
+ size_t get_number_of_arguments() const override {
+ return get_variadic_argument_types_impl().size();
+ }
+ DataTypePtr get_return_type_impl(const DataTypes& arguments) const
override {
+ return make_nullable(std::make_shared<DataTypeJsonb>());
+ }
+ bool use_default_implementation_for_nulls() const override { return false;
}
+
+ Status open(FunctionContext* context, FunctionContext::FunctionStateScope
scope) override {
+ if (scope != FunctionContext::THREAD_LOCAL) {
+ return Status::OK();
+ }
+ if (context->is_col_constant(2)) {
+ std::shared_ptr<LikeState> state = std::make_shared<LikeState>();
+ state->is_like_pattern = true;
+ // The default is \ if the escape_char argument is missing or NULL.
+ // Otherwise, escape_char must be a constant that is empty or one
character.
+ state->search_state.escape_char = '\\';
+ const auto pattern_col = context->get_constant_col(2)->column_ptr;
+ const auto& pattern = pattern_col->get_data_at(0);
+ RETURN_IF_ERROR(
+ FunctionLike::construct_like_const_state(context, pattern,
state, false));
+ context->set_function_state(scope, state);
+ }
+ return Status::OK();
+ }
+
+ Status execute_impl(FunctionContext* context, Block& block, const
ColumnNumbers& arguments,
+ uint32_t result, size_t input_rows_count) const
override {
+ return Impl::execute_impl(context, block, arguments, result,
input_rows_count);
+ }
+};
+
+#define JSON_SEARCH_NORMAL_PREPARE()
\
+ JsonSearchUtil::CheckNullFun json_null_check =
JsonSearchUtil::always_not_null; \
+ JsonSearchUtil::GetJsonStringRefFun get_json_fun;
\
+
\
+ JsonSearchUtil::CheckNullFun one_null_check =
JsonSearchUtil::always_not_null; \
+ JsonSearchUtil::OneFun one_check = JsonSearchUtil::always_one;
\
+
\
+ JsonSearchUtil::CheckNullFun search_null_check =
JsonSearchUtil::always_not_null; \
+ const ColumnString* col_search_string;
\
+ bool search_is_const = false;
\
+
\
+ RETURN_IF_ERROR(JsonSearchUtil::execute_prepare(
\
+ context, block, arguments, json_null_check, get_json_fun,
one_null_check, one_check, \
+ search_null_check, col_search_string, &search_is_const))
+
+struct JsonSearchNormal {
+ static DataTypes get_variadic_argument_types() {
+ return {
+ std::make_shared<DataTypeString>(),
+ std::make_shared<DataTypeString>(),
+ std::make_shared<DataTypeString>(),
+ };
+ }
+
+ static Status execute_impl(FunctionContext* context, Block& block,
+ const ColumnNumbers& arguments, uint32_t result,
+ size_t input_rows_count) {
+ if (arguments.size() != 3) {
+ return Status::InvalidArgument("wrong arguments for function
json_search");
+ }
+
+ JSON_SEARCH_NORMAL_PREPARE();
+
+ if (search_is_const) {
+ RETURN_IF_ERROR(JsonSearchUtil::execute_vector<true>(
block, input_rows_count, json_null_check, get_json_fun,
one_null_check,
one_check, search_null_check, col_search_string, context,
result));
} else {
- CheckNullFun search_null_check = [col_search](size_t i) {
- return col_search->is_null_at(i);
- };
- RETURN_IF_ERROR(execute_vector<false>(
+ RETURN_IF_ERROR(JsonSearchUtil::execute_vector<false>(
block, input_rows_count, json_null_check, get_json_fun,
one_null_check,
one_check, search_null_check, col_search_string, context,
result));
}
+
+ return Status::OK();
+ }
+};
+
+#define JSON_SEARCH_EXTRA_PREPARE(arg_name, index, null_check_fn, get_type,
get_fn) \
+ JsonSearchUtil::CheckNullFun arg_name##_null_check =
JsonSearchUtil::always_null; \
+ get_type get_##arg_name##_string;
\
+
\
+ ColumnPtr col_##arg_name;
\
+ bool arg_name##_is_const = false;
\
+ const ColumnString* col_##arg_name##_string;
\
+
\
+ RETURN_IF_ERROR(JsonSearchUtil::parse_column_args(context, block,
arguments, index, \
+ &arg_name##_is_const,
col_##arg_name, \
+
col_##arg_name##_string)); \
+
\
+ if (arg_name##_is_const) {
\
+ if (col_##arg_name->is_null_at(0)) {
\
+ arg_name##_null_check = JsonSearchUtil::always_null;
\
+ }
\
+ } else {
\
+ arg_name##_null_check = null_check_fn;
\
+ get_##arg_name##_string = get_fn;
\
+ }
+
+#define JSON_SEARCH_EXTRA_PREPARE_ESCAPE()
\
+ JsonSearchUtil::CheckNullFun escape_null_check =
JsonSearchUtil::always_null; \
+ JsonSearchUtil::GetJsonEscapeFun get_escape_string;
\
+
\
+ ColumnPtr col_escape;
\
+ bool escape_is_const = false;
\
+ const ColumnString* col_escape_string;
\
+
\
+ RETURN_IF_ERROR(JsonSearchUtil::parse_column_args(
\
+ context, block, arguments, 3, &escape_is_const, col_escape,
col_escape_string)); \
+
\
+ if (!escape_is_const) {
\
+ /* return Status::RuntimeError("JsonSearch escape_char CANNOT be
non-constant column");*/ \
Review Comment:
Here, I will check that the escape parameter is a constant column, **but
when I passed the be ut test, I found that it kept returning `false`, which
means it is not a constant column.** How should I solve it? @liutang123
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
