HappenLee commented on code in PR #50126: URL: https://github.com/apache/doris/pull/50126#discussion_r2055467437
########## be/src/util/uuid_generator.h: ########## @@ -17,18 +17,74 @@ #pragma once +#include <atomic> #include <boost/uuid/uuid.hpp> #include <boost/uuid/uuid_generators.hpp> #include <boost/uuid/uuid_io.hpp> +#include <chrono> +#include <cstdint> #include <mutex> +#include <random> namespace doris { +// Format: Review Comment: @dolfinus could please add a benchmark to show performance between of new `next_uuid()` and ` _boost_uuid_generator()` use like : https://quick-bench.com/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org