zhannngchen commented on code in PR #50062:
URL: https://github.com/apache/doris/pull/50062#discussion_r2055465281
##########
cloud/src/recycler/checker.cpp:
##########
@@ -1189,4 +1195,52 @@ int
InstanceChecker::do_delete_bitmap_storage_optimize_check() {
return (failed_tablets_num > 0) ? 1 : 0;
}
+int InstanceChecker::do_compaction_key_check() {
+ std::unique_ptr<RangeGetIterator> it;
+ std::string begin = mow_tablet_compaction_key({instance_id_, 0, 0});
+ std::string end = mow_tablet_compaction_key({instance_id_, INT64_MAX, 0});
+ MowTabletCompactionPB mow_tablet_compaction;
+ do {
+ std::unique_ptr<Transaction> txn;
+ TxnErrorCode err = txn_kv_->create_txn(&txn);
+ if (err != TxnErrorCode::TXN_OK) {
+ LOG(WARNING) << "failed to create txn";
+ return -1;
+ }
+ err = txn->get(begin, end, &it);
+ if (err != TxnErrorCode::TXN_OK) {
+ LOG(WARNING) << "failed to get mow tablet compaction key, err=" <<
err;
+ return -1;
+ }
+ int64_t now = duration_cast<std::chrono::seconds>(
+
std::chrono::system_clock::now().time_since_epoch())
+ .count();
+ while (it->has_next() && !stopped()) {
+ auto [k, v] = it->next();
+ std::string_view k1 = k;
+ k1.remove_prefix(1);
+ std::vector<std::tuple<std::variant<int64_t, std::string>, int,
int>> out;
+ decode_key(&k1, &out);
+ // 0x01 "meta" ${instance_id} "mow_tablet_comp" ${table_id}
${initiator}
+ auto table_id = std::get<int64_t>(std::get<0>(out[3]));
+ auto initiator = std::get<int64_t>(std::get<0>(out[4]));
+ LOG(INFO) << "table_id=" << table_id << ",initiator=" << initiator;
+ if (!mow_tablet_compaction.ParseFromArray(v.data(), v.size()))
[[unlikely]] {
+ LOG(WARNING) << "failed to parse MowTabletCompactionPB";
+ return -1;
+ }
+ int64_t expiration = mow_tablet_compaction.expiration();
+ if (expiration < now -
config::compaction_key_check_expiration_diff_seconds) {
+ LOG(WARNING) << fmt::format(
Review Comment:
it’s also necessary to check whether the corresponding compaction lock key
still exists. If it does, this situation might be expected and does not require
an warning log and error response.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
