taptao commented on code in PR #50310:
URL: https://github.com/apache/doris/pull/50310#discussion_r2055240466


##########
be/src/vec/exprs/table_function/table_function_factory.cpp:
##########
@@ -61,14 +63,21 @@ const std::unordered_map<std::string, 
std::function<std::unique_ptr<TableFunctio
                 {"explode_map", TableFunctionCreator<VExplodeMapTableFunction> 
{}},
                 {"explode_json_object", 
TableFunctionCreator<VExplodeJsonObjectTableFunction> {}},
                 {"posexplode", TableFunctionCreator<VPosExplodeTableFunction> 
{}},
-                {"explode", TableFunctionCreator<VExplodeTableFunction> {}}};
+                {"explode", TableFunctionCreator<VExplodeV2TableFunction> {}},
+                {"explode_old", TableFunctionCreator<VExplodeTableFunction> 
{}}};

Review Comment:
   目前背景, explode_old 
函数保留只是为了升级场景,当升级完成后,这个函数可以被移除,所以没有考虑多版本的情况。以及这个函数名称和函数注册地方相关,暂时没做多版本的注册控制,只补充了新版和旧版的控制。
   我可以对 VExplodeV2TableFunction 补充下注释信息,写明变更的原因和变更内容。



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to