gavinchou commented on code in PR #50275:
URL: https://github.com/apache/doris/pull/50275#discussion_r2054450342


##########
be/src/io/cache/block_file_cache_downloader.cpp:
##########
@@ -229,6 +230,7 @@ void FileCacheBlockDownloader::download_segment_file(const 
DownloadFileMeta& met
         // TODO(plat1ko):
         //  1. Directly append buffer data to file cache
         //  2. Provide `FileReader::async_read()` interface
+        meta.ctx.is_dryrun = true;

Review Comment:
   why meta.is_dryrun is not set by the caller?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to