morrySnow commented on code in PR #49918: URL: https://github.com/apache/doris/pull/49918#discussion_r2053785046
########## fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/logical/LogicalCommonHint.java: ########## @@ -0,0 +1,96 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package org.apache.doris.nereids.trees.plans.logical; + +import org.apache.doris.nereids.memo.GroupExpression; +import org.apache.doris.nereids.properties.LogicalProperties; +import org.apache.doris.nereids.trees.expressions.Expression; +import org.apache.doris.nereids.trees.expressions.Slot; +import org.apache.doris.nereids.trees.plans.BlockFuncDepsPropagation; +import org.apache.doris.nereids.trees.plans.DiffOutputInAsterisk; +import org.apache.doris.nereids.trees.plans.Plan; +import org.apache.doris.nereids.trees.plans.PlanType; +import org.apache.doris.nereids.trees.plans.visitor.PlanVisitor; + +import com.google.common.base.Preconditions; +import com.google.common.collect.ImmutableList; + +import java.util.List; +import java.util.Optional; + +/** + * Common hint. Now we only support PREAGGOPEN + */ +public class LogicalCommonHint<CHILD_TYPE extends Plan> extends LogicalUnary<CHILD_TYPE> + implements BlockFuncDepsPropagation, DiffOutputInAsterisk { + + private final boolean preAggEnabledByHint; + + public LogicalCommonHint(CHILD_TYPE child) { + this(Optional.empty(), Optional.empty(), child); + } + + /** + * LogicalCommonHint's full parameter constructor. + * @param groupExpression groupExpression exists when this plan is copy out from memo. + * @param logicalProperties logicalProperties is use for compute output + * @param child child plan + */ + public LogicalCommonHint(Optional<GroupExpression> groupExpression, Review Comment: if this hint only support pre agg on, we should rename it. and remove the attribute `preAggEnabledByHint`. after we refactor it and let it support other hint, we rename it back to current name. ########## fe/fe-core/src/main/java/org/apache/doris/nereids/rules/analysis/EliminateLogicalCommonHint.java: ########## @@ -0,0 +1,42 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package org.apache.doris.nereids.rules.analysis; + +import org.apache.doris.nereids.rules.Rule; +import org.apache.doris.nereids.rules.RuleType; +import org.apache.doris.nereids.rules.rewrite.OneRewriteRuleFactory; +import org.apache.doris.nereids.trees.plans.Plan; +import org.apache.doris.nereids.trees.plans.logical.LogicalCommonHint; + +import com.google.common.base.Preconditions; + +/** + * eliminate logical common hint and set them to cascade context + */ +public class EliminateLogicalCommonHint extends OneRewriteRuleFactory { + + @Override + public Rule build() { + return logicalCommonHint().thenApply(ctx -> { + LogicalCommonHint<Plan> commonHintPlan = ctx.root; + Preconditions.checkArgument(commonHintPlan.preAggEnabledByHint(), "common hint only support PREAGGOPEN"); Review Comment: should not check here, because hint should not lead to fail. if we could not recognize this hint, just ignore it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
