This is an automated email from the ASF dual-hosted git repository.
gavinchou pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new bb625d52213 [fix](cloud) remove unnecessary DCHECK existence when
delete file cache directory (#50049)
bb625d52213 is described below
commit bb625d522131f18b37542a9773a2f79ebb631ad5
Author: zhengyu <zhangzhen...@selectdb.com>
AuthorDate: Mon Apr 21 22:17:30 2025 +0800
[fix](cloud) remove unnecessary DCHECK existence when delete file cache
directory (#50049)
Remove has been make async in recent code base, so multiple threads
could operate on filesystem. The DCHECK is not guranteed to be exist no
more and such DCHECK becomes unnecessary
The deletion is meant to make the directory disappear and the removal
logic will handle the non-existence case correctly.
---
be/src/io/cache/fs_file_cache_storage.cpp | 1 -
1 file changed, 1 deletion(-)
diff --git a/be/src/io/cache/fs_file_cache_storage.cpp
b/be/src/io/cache/fs_file_cache_storage.cpp
index 9e24970d8b3..01900fbd2a5 100644
--- a/be/src/io/cache/fs_file_cache_storage.cpp
+++ b/be/src/io/cache/fs_file_cache_storage.cpp
@@ -217,7 +217,6 @@ Status FSFileCacheStorage::remove(const FileCacheKey& key) {
std::vector<FileInfo> files;
bool exists {false};
RETURN_IF_ERROR(fs->list(dir, true, &files, &exists));
- DCHECK(exists);
if (files.empty()) {
RETURN_IF_ERROR(fs->delete_directory(dir));
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
