yiguolei commented on code in PR #50107:
URL: https://github.com/apache/doris/pull/50107#discussion_r2051444920
##########
be/src/runtime/query_context.h:
##########
@@ -348,50 +260,23 @@ class QueryContext : public
std::enable_shared_from_this<QueryContext> {
return _using_brpc_stubs;
}
- void set_low_memory_mode() { _low_memory_mode = true; }
-
- bool low_memory_mode() { return _low_memory_mode; }
-
- void disable_reserve_memory() { _enable_reserve_memory = false; }
-
- bool enable_reserve_memory() const {
- return _query_options.__isset.enable_reserve_memory &&
- _query_options.enable_reserve_memory && _enable_reserve_memory;
- }
-
- void update_paused_reason(const Status& st) {
- std::lock_guard l(_paused_mutex);
- if (_paused_reason.is<ErrorCode::QUERY_MEMORY_EXCEEDED>()) {
- return;
- } else if
(_paused_reason.is<ErrorCode::WORKLOAD_GROUP_MEMORY_EXCEEDED>()) {
- if (st.is<ErrorCode::QUERY_MEMORY_EXCEEDED>()) {
- _paused_reason = st;
- return;
- } else {
- return;
- }
- } else {
- _paused_reason = st;
- }
- }
-
- Status paused_reason() {
- std::lock_guard l(_paused_mutex);
- return _paused_reason;
+ void set_low_memory_mode(bool low_memory_mode = true) {
Review Comment:
不要加这个参数，我们的设计不会从low memory mode 退回到非low memory mode
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
