airborne12 commented on code in PR #50145:
URL: https://github.com/apache/doris/pull/50145#discussion_r2051367733
##########
be/src/olap/compaction.cpp:
##########
@@ -895,94 +910,104 @@ void
Compaction::construct_index_compaction_columns(RowsetWriterContext& ctx) {
return false;
}
- const auto* index_meta =
rowset->tablet_schema()->inverted_index(col_unique_id);
-
DBUG_EXECUTE_IF("Compaction::construct_skip_inverted_index_index_meta_nullptr",
- { index_meta = nullptr; })
- if (index_meta == nullptr) {
- LOG(WARNING) << "tablet[" << _tablet->tablet_id() << "]
column_unique_id["
- << col_unique_id << "] index meta is null, will
skip index compaction";
- return false;
- }
+ auto index_metas =
rowset->tablet_schema()->inverted_indexs(col_unique_id);
Review Comment:
maybe when index_metas.empty(), we also need to return false.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
