HappenLee commented on code in PR #50082:
URL: https://github.com/apache/doris/pull/50082#discussion_r2046135399
##########
be/src/vec/functions/function_binary_arithmetic.h:
##########
@@ -1117,6 +1094,87 @@ class FunctionBinaryArithmetic : public IFunction {
return Status::OK();
}
+
+ Status execute_impl(FunctionContext* context, Block& block, const
ColumnNumbers& arguments,
+ uint32_t result, size_t input_rows_count) const
override {
+ auto* state = reinterpret_cast<BinaryArithmeticState*>(
+ context->get_function_state(FunctionContext::FRAGMENT_LOCAL));
+ if (!state) {
+ return Status::RuntimeError("function context for function '{}'
must have Set;",
Review Comment:
must have Set ？
##########
be/src/vec/functions/function_binary_arithmetic.h:
##########
@@ -1117,6 +1094,87 @@ class FunctionBinaryArithmetic : public IFunction {
return Status::OK();
}
+
+ Status execute_impl(FunctionContext* context, Block& block, const
ColumnNumbers& arguments,
+ uint32_t result, size_t input_rows_count) const
override {
+ auto* state = reinterpret_cast<BinaryArithmeticState*>(
+ context->get_function_state(FunctionContext::FRAGMENT_LOCAL));
+ if (!state) {
Review Comment:
if(!state or !state->impl)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
