yiguolei commented on code in PR #11001:
URL: https://github.com/apache/doris/pull/11001#discussion_r925470048


##########
be/src/olap/tablet_meta.cpp:
##########
@@ -636,7 +636,6 @@ void TabletMeta::modify_rs_metas(const 
std::vector<RowsetMetaSharedPtr>& to_add,
 // an existing tablet before. Add after revise, only the passing "rs_metas"
 // is needed.
 void TabletMeta::revise_rs_metas(std::vector<RowsetMetaSharedPtr>&& rs_metas) {
-    std::lock_guard<std::shared_mutex> wrlock(_meta_lock);

Review Comment:
   I am not sure, but I think we'd better not merge this PR. 
   These code is written by me. I will think about it why I use two locks here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to