morningman commented on code in PR #49688:
URL: https://github.com/apache/doris/pull/49688#discussion_r2045591967


##########
fe/fe-core/src/main/java/org/apache/doris/common/profile/SummaryProfile.java:
##########
@@ -399,6 +410,22 @@ public void update(Map<String, String> summaryInfo) {
         updateExecutionSummaryProfile();
     }
 
+    public void queryFinished() {

Review Comment:
   Add comment to explain what is this method for and why we need this



##########
fe/fe-core/src/main/java/org/apache/doris/common/profile/SummaryProfile.java:
##########
@@ -340,6 +349,8 @@ public class SummaryProfile {
     private Map<TNetworkAddress, List<Long>> rpcPhase1Latency;
     private Map<TNetworkAddress, List<Long>> rpcPhase2Latency;
 
+    Map<Backend, Long> assignedWeightPerBackend;

Review Comment:
   ```suggestion
       private Map<Backend, Long> assignedWeightPerBackend;
   ```



##########
fe/fe-core/src/main/java/org/apache/doris/datasource/paimon/source/PaimonScanNode.java:
##########
@@ -344,6 +346,8 @@ public List<Split> getSplits(int numBackends) throws 
UserException {
             splitStats.add(splitStat);
         }
 
+        splits.forEach(s -> s.setTargetSplitSize(realFileSplitSize));

Review Comment:
   Is this a bug?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to