adonis0147 commented on code in PR #10667:
URL: https://github.com/apache/doris/pull/10667#discussion_r925381603
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/CompoundPredicate.java:
##########
@@ -58,7 +58,7 @@ public <R, C> R accept(ExpressionVisitor<R, C> visitor, C
context) {
@Override
public Expression withChildren(List<Expression> children) {
- return new CompoundPredicate(getType(), children.get(0),
children.get(1));
+ throw new RuntimeException("Do not implement this method");
Review Comment:
Use `Do not implement this method` as a comment. For the exception message,
I think it is better to use another description.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
