seawinde commented on code in PR #49041:
URL: https://github.com/apache/doris/pull/49041#discussion_r2043402580


##########
fe/fe-core/src/main/java/org/apache/doris/mtmv/MTMVPlanUtil.java:
##########
@@ -150,4 +173,117 @@ public static Set<TableIf> getBaseTableFromQuery(String 
querySql, ConnectContext
             }
         }
     }
+
+    public static List<ColumnDefinition> generateColumnsBySql(String querySql, 
ConnectContext ctx, String partitionCol,

Review Comment:
   the ConnectContext may be init a new instance is better, the same logic 
method is `org.apache.doris.mtmv.MTMVCache#from` may be reused is better



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to