morrySnow commented on code in PR #49984: URL: https://github.com/apache/doris/pull/49984#discussion_r2038821228
########## fe/fe-core/src/main/java/org/apache/doris/qe/StmtExecutor.java: ########## @@ -3527,6 +3529,10 @@ public List<ResultRow> executeInternalQuery() { UUID uuid = UUID.randomUUID(); TUniqueId queryId = new TUniqueId(uuid.getMostSignificantBits(), uuid.getLeastSignificantBits()); context.setQueryId(queryId); + String stmt = SqlDialectHelper.convertSqlByDialect(originStmt.originStmt, context.getSessionVariable()); Review Comment: internal sql is always written with Doris' dialect, so it should not convert by dialect? ########## fe/fe-core/src/main/java/org/apache/doris/qe/StmtExecutor.java: ########## @@ -3527,6 +3529,10 @@ public List<ResultRow> executeInternalQuery() { UUID uuid = UUID.randomUUID(); TUniqueId queryId = new TUniqueId(uuid.getMostSignificantBits(), uuid.getLeastSignificantBits()); context.setQueryId(queryId); + String stmt = SqlDialectHelper.convertSqlByDialect(originStmt.originStmt, context.getSessionVariable()); + if (stmt != null) { + context.setSqlHash(DigestUtils.md5Hex(stmt)); + } Review Comment: could we add a ut to ensure it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org