gavinchou commented on code in PR #49945:
URL: https://github.com/apache/doris/pull/49945#discussion_r2036608470
##########
be/src/pipeline/exec/olap_scan_operator.cpp:
##########
@@ -441,76 +441,70 @@ Status OlapScanLocalState::hold_tablets() {
return Status::OK();
}
- auto update_sync_rowset_profile = [&](const SyncRowsetStats& sync_stat) {
- COUNTER_UPDATE(_sync_rowset_get_remote_rowsets_num,
sync_stat.get_remote_rowsets_num);
- COUNTER_UPDATE(_sync_rowset_get_remote_rowsets_rpc_timer,
- sync_stat.get_remote_rowsets_rpc_ms);
- COUNTER_UPDATE(_sync_rowset_get_local_delete_bitmap_rowsets_num,
- sync_stat.get_local_delete_bitmap_rowsets_num);
- COUNTER_UPDATE(_sync_rowset_get_remote_delete_bitmap_rowsets_num,
- sync_stat.get_remote_delete_bitmap_rowsets_num);
- COUNTER_UPDATE(_sync_rowset_get_remote_delete_bitmap_key_count,
- sync_stat.get_remote_delete_bitmap_key_count);
- COUNTER_UPDATE(_sync_rowset_get_remote_delete_bitmap_bytes,
- sync_stat.get_remote_delete_bitmap_bytes);
- COUNTER_UPDATE(_sync_rowset_get_remote_delete_bitmap_rpc_timer,
- sync_stat.get_remote_delete_bitmap_rpc_ms);
- };
-
MonotonicStopWatch timer;
timer.start();
_tablets.resize(_scan_ranges.size());
_read_sources.resize(_scan_ranges.size());
- for (size_t i = 0; i < _scan_ranges.size(); i++) {
- int64_t version = 0;
- std::from_chars(_scan_ranges[i]->version.data(),
- _scan_ranges[i]->version.data() +
_scan_ranges[i]->version.size(), version);
- if (config::is_cloud_mode()) {
- int64_t duration_ns = 0;
- SyncRowsetStats sync_stats;
- {
- SCOPED_RAW_TIMER(&duration_ns);
- auto tablet =
-
DORIS_TRY(ExecEnv::get_tablet(_scan_ranges[i]->tablet_id, &sync_stats));
- _tablets[i] = {std::move(tablet), version};
- }
- COUNTER_UPDATE(_sync_rowset_timer, duration_ns);
- update_sync_rowset_profile(sync_stats);
-
- // FIXME(plat1ko): Avoid pointer cast
-
ExecEnv::GetInstance()->storage_engine().to_cloud().tablet_hotspot().count(
- *_tablets[i].tablet);
- } else {
- auto tablet =
DORIS_TRY(ExecEnv::get_tablet(_scan_ranges[i]->tablet_id));
- _tablets[i] = {std::move(tablet), version};
- }
- }
if (config::is_cloud_mode()) {
- int64_t duration_ns = 0;
std::vector<SyncRowsetStats> sync_statistics {};
- sync_statistics.reserve(_tablets.size());
+ sync_statistics.reserve(_scan_ranges.size());
Review Comment:
better extract code block `if (cloud)` to function
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
