BiteTheDDDDt commented on code in PR #49772:
URL: https://github.com/apache/doris/pull/49772#discussion_r2034338922
##########
be/src/pipeline/exec/set_probe_sink_operator.cpp:
##########
@@ -144,22 +144,19 @@ Status
SetProbeSinkOperatorX<is_intersect>::_extract_probe_column(
vectorized::ColumnRawPtrs& raw_ptrs, int child_id) {
auto& build_not_ignore_null =
local_state._shared_state->build_not_ignore_null;
- for (size_t i = 0; i < _child_exprs.size(); ++i) {
+ auto& child_exprs = local_state._child_exprs;
+ for (size_t i = 0; i < child_exprs.size(); ++i) {
int result_col_id = -1;
- RETURN_IF_ERROR(_child_exprs[i]->execute(&block, &result_col_id));
+ RETURN_IF_ERROR(child_exprs[i]->execute(&block, &result_col_id));
block.get_by_position(result_col_id).column =
block.get_by_position(result_col_id).column->convert_to_full_column_if_const();
- auto column = block.get_by_position(result_col_id).column.get();
-
- if (auto* nullable =
check_and_get_column<vectorized::ColumnNullable>(*column)) {
- auto& col_nested = nullable->get_nested_column();
- if (build_not_ignore_null[i]) { //same as build column
- raw_ptrs[i] = nullable;
- } else {
- raw_ptrs[i] = &col_nested;
- }
+ const auto* column = block.get_by_position(result_col_id).column.get();
+ if (const auto* nullable =
check_and_get_column<vectorized::ColumnNullable>(*column)) {
+ DCHECK(build_not_ignore_null[i])
Review Comment:
尽量都返回error status吧
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
