zclllyybb commented on code in PR #49876:
URL: https://github.com/apache/doris/pull/49876#discussion_r2032959797
##########
be/src/vec/aggregate_functions/aggregate_function_sort.h:
##########
@@ -90,7 +90,11 @@ struct AggregateFunctionSortData {
PBlock pblock;
pblock.ParseFromString(data);
auto st = block.deserialize(pblock);
- CHECK(st.ok());
+ // If memory allocate failed during deserialize, st is not ok, throw
exception here to
+ // stop the query.
+ if (!st.ok()) {
+ throw doris::Exception(ErrorCode::INTERNAL_ERROR, st.to_string());
Review Comment:
we have more proper ErrorCode MemoryLimitExceeded
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
