yiguolei commented on code in PR #49777:
URL: https://github.com/apache/doris/pull/49777#discussion_r2032277499
##########
be/src/olap/column_predicate.h:
##########
@@ -255,31 +255,18 @@ class ColumnPredicate {
int get_runtime_filter_id() const { return _runtime_filter_id; }
- void set_runtime_filter_info(int filter_id,
- RuntimeProfile::Counter*
predicate_filtered_rows_counter,
- RuntimeProfile::Counter*
predicate_input_rows_counter) {
- if (filter_id >= 0) {
- DCHECK(predicate_filtered_rows_counter != nullptr);
- DCHECK(predicate_input_rows_counter != nullptr);
- }
+ void attach_profile_counter(
+ int filter_id, std::shared_ptr<RuntimeProfile::Counter>
predicate_filtered_rows_counter,
+ std::shared_ptr<RuntimeProfile::Counter>
predicate_input_rows_counter) {
_runtime_filter_id = filter_id;
Review Comment:
这里，得确保，新attach的counter ！= nullptr
如果是，直接throw exception。否则万一上层的逻辑有问题，这里就直接core了
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
