yiguolei commented on code in PR #49281:
URL: https://github.com/apache/doris/pull/49281#discussion_r2005367785
##########
be/src/pipeline/dependency.cpp:
##########
@@ -68,32 +68,42 @@ void Dependency::set_ready() {
local_block_task.swap(_blocked_task);
}
for (auto* task : local_block_task) {
- task->wake_up();
+ {
+ std::unique_lock<std::mutex> lc(_task_lock);
+ DCHECK_EQ(task->_blocked_dep, this)
+ << "dep : " << debug_string(0) << "task: " <<
debug_string();
+ task->_blocked_dep = nullptr;
Review Comment:
不要这么访问private 变量，一旦成为飞线后面不好维护；
而且，75 行和76 行，得封装到task 里做一个单独的函数，这种task的状态变迁，不能暴露给外部。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
