gnehil commented on code in PR #305:
URL:
https://github.com/apache/doris-spark-connector/pull/305#discussion_r2027081857
##########
spark-doris-connector/spark-doris-connector-base/src/main/java/org/apache/doris/spark/client/write/AbstractStreamLoadProcessor.java:
##########
@@ -402,9 +418,32 @@ private Future<CloseableHttpResponse>
buildReqAndExec(String host, Integer port,
entity = new GzipCompressingEntity(entity);
}
httpPut.setEntity(entity);
-
- logger.info("table {}.{} stream load started for {} on host {}:{}",
database, table, currentLabel != null ? currentLabel : "group commit", host,
port);
- return getExecutors().submit(() -> client.execute(httpPut));
+ Thread currentThread = Thread.currentThread();
+
+ logger.info("table {}.{} stream load started for {} on host {}:{}",
database, table,
+ currentLabel != null ? currentLabel : "group commit", host,
port);
+ return getExecutors().submit(() -> {
+ CloseableHttpResponse response = client.execute(httpPut);
+ // stream load http request finished unexpectedly
+ if (!isStopped) {
Review Comment:
No, I put the isStopped setting after requestFuture.get() of the stop
method, which ensures that isStopped is true when the http request ends the
batch normally through the stop method, and false otherwise.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
