yiguolei commented on code in PR #10896:
URL: https://github.com/apache/doris/pull/10896#discussion_r922673493
##########
be/src/io/fs/local_file_system.cpp:
##########
@@ -56,28 +47,16 @@ Status LocalFileSystem::create_file(const Path& path,
std::unique_ptr<FileWriter
return Status::OK();
}
-Status LocalFileSystem::open_file(const Path& path,
std::unique_ptr<FileReader>* reader) {
+Status LocalFileSystem::open_file(const Path& path, FileReaderPtr* reader) {
auto fs_path = absolute_path(path);
- std::shared_ptr<OpenedFileHandle<int>> file_handle(new
OpenedFileHandle<int>());
- bool found = _file_cache->lookup(fs_path.native(), file_handle.get());
Review Comment:
file cache is useless?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
