morningman commented on code in PR #49545:
URL: https://github.com/apache/doris/pull/49545#discussion_r2017873715
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/hive/HMSDlaTable.java:
##########
@@ -76,4 +76,8 @@ public void beforeMTMVRefresh(MTMV mtmv) throws DdlException {
Env.getCurrentEnv().getRefreshManager()
.refreshTable(hmsTable.getCatalog().getName(),
hmsTable.getDbName(), hmsTable.getName(), true);
}
+
+ boolean isValidRelatedTable() {
Review Comment:
Add comment to explain this method
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/hive/HMSExternalCatalog.java:
##########
@@ -187,6 +187,12 @@ protected void initLocalObjectsImpl() {
transactionManager =
TransactionManagerFactory.createHiveTransactionManager(hiveOps,
fileSystemProvider,
fileSystemExecutor);
metadataOps = hiveOps;
+ threadPoolWithPreAuth =
ThreadPoolManager.newDaemonFixedThreadPoolWithPreAuth(
+ ICEBERG_CATALOG_EXECUTOR_THREAD_NUM,
+ Integer.MAX_VALUE,
+ String.format("hms_catalog_%s_executor_pool", name),
Review Comment:
Is this only for iceberg? If yes, the name better contains "iceberg"
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/hive/HMSDlaTable.java:
##########
@@ -76,4 +76,8 @@ public void beforeMTMVRefresh(MTMV mtmv) throws DdlException {
Env.getCurrentEnv().getRefreshManager()
.refreshTable(hmsTable.getCatalog().getName(),
hmsTable.getDbName(), hmsTable.getName(), true);
}
+
+ boolean isValidRelatedTable() {
Review Comment:
```suggestion
protected boolean isValidRelatedTable() {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
