suxiaogang223 opened a new pull request, #49641:
URL: https://github.com/apache/doris/pull/49641

   Problem Summary:
   In HiveMetaStoreCache, the function FileInputFormat.setInputPaths is used to 
set input paths. However, this function splits paths using commas, which is not 
the expected behavior. As a result, when partition values contain commas, it 
leads to incorrect path parsing and potential errors.
   ```java
     public static void setInputPaths(JobConf conf, String 
org.apache.hadoop.shaded.com.aSeparatedPaths) {
       setInputPaths(conf, StringUtils.stringToPath(
                           
getPathStrings(org.apache.hadoop.shaded.com.aSeparatedPaths)));
     }
   ```
   To prevent FileInputFormat.setInputPaths from splitting paths by commas, we 
use another overloaded version of the method. Instead of passing a 
comma-separated string, we explicitly pass a Path object, ensuring that 
partition values containing commas are handled correctly.
   ```java
     public static void setInputPaths(JobConf conf, Path... inputPaths) {
       Path path = new Path(conf.getWorkingDirectory(), inputPaths[0]);
       StringBuffer str = new 
StringBuffer(StringUtils.escapeString(path.toString()));
       for(int i = 1; i < inputPaths.length;i++) {
         str.append(StringUtils.COMMA_STR);
         path = new Path(conf.getWorkingDirectory(), inputPaths[i]);
         str.append(StringUtils.escapeString(path.toString()));
       }
       conf.set(org.apache.hadoop.shaded.org.apache.hadoop.mapreduce.lib.input.
         FileInputFormat.INPUT_DIR, str.toString());
     }
   ```
   
   ### What problem does this PR solve?
   
   Issue Number: close #xxx
   
   Related PR: #xxx
   
   Problem Summary:
   
   ### Release note
   
   None
   
   ### Check List (For Author)
   
   - Test <!-- At least one of them must be included. -->
       - [ ] Regression test
       - [ ] Unit Test
       - [ ] Manual test (add detailed scripts or steps below)
       - [ ] No need to test or manual test. Explain why:
           - [ ] This is a refactor/code format and no logic has been changed.
           - [ ] Previous test can cover this change.
           - [ ] No code files have been changed.
           - [ ] Other reason <!-- Add your reason?  -->
   
   - Behavior changed:
       - [ ] No.
       - [ ] Yes. <!-- Explain the behavior change -->
   
   - Does this need documentation?
       - [ ] No.
       - [ ] Yes. <!-- Add document PR link here. eg: 
https://github.com/apache/doris-website/pull/1214 -->
   
   ### Check List (For Reviewer who merge this PR)
   
   - [ ] Confirm the release note
   - [ ] Confirm test cases
   - [ ] Confirm document
   - [ ] Add branch pick label <!-- Add branch pick label that this PR should 
merge into -->
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to