JNSimba commented on code in PR #285:
URL:
https://github.com/apache/doris-spark-connector/pull/285#discussion_r2018163122
##########
spark-doris-connector/spark-doris-connector-base/src/main/java/org/apache/doris/spark/client/write/AbstractStreamLoadProcessor.java:
##########
@@ -143,14 +144,26 @@ public AbstractStreamLoadProcessor(DorisConfig config)
throws Exception {
public void load(R row) throws Exception {
if (createNewBatch) {
if (autoRedirect) {
- requestFuture = frontend.requestFrontends((frontEnd,
httpClient) ->
- buildReqAndExec(frontEnd.getHost(),
frontEnd.getHttpPort(), httpClient));
+ requestFuture = frontend.requestFrontends((frontEnd,
httpClient) -> {
+ if (isTwoPhaseCommitEnabled && frontEnd.getHttpPort() <=
0) {
+ throw new IllegalArgumentException("option [" +
DorisOptions.DORIS_FENODES.getName()
+ + "] is not in correct format when ["
+ + DorisOptions.DORIS_SINK_ENABLE_2PC.getName()
+ " = true"
+ + "], for example: host:port[,host2:port]");
+ }
Review Comment:
Why do we need to check isTwoPhaseCommitEnabled one more time here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
