HappenLee commented on code in PR #49429:
URL: https://github.com/apache/doris/pull/49429#discussion_r2018150393


##########
be/src/vec/runtime/vdatetime_value.h:
##########
@@ -1533,16 +1533,34 @@ int64_t datetime_diff(const DateV2Value<T0>& ts_value1, 
const DateV2Value<T1>& t
     }
     case HOUR: {
         int64_t second = ts_value2.second_diff(ts_value1);
+        int32_t ms_diff = ts_value2.microsecond() - ts_value1.microsecond();

Review Comment:
   consider be a function



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to