morrySnow commented on code in PR #49575:
URL: https://github.com/apache/doris/pull/49575#discussion_r2018028852
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/executable/NumericArithmetic.java:
##########
@@ -966,7 +966,7 @@ public static Expression atan(DoubleLiteral first) {
*/
@ExecFunction(name = "asinh")
public static Expression asinh(DoubleLiteral first) {
- if (inputOutOfBound(first, Double.NEGATIVE_INFINITY,
Double.POSITIVE_INFINITY, false, false)) {
+ if (inputOutOfBound(first, Double.NEGATIVE_INFINITY,
Double.POSITIVE_INFINITY, true, true)) {
Review Comment:
if the bound is `[-inf, inf]` why still need to check bound?
##########
regression-test/suites/nereids_p0/expression/fold_constant/fold_constant_cast.groovy:
##########
@@ -31,12 +31,12 @@ suite("fold_constant_cast") {
testFoldConst("SELECT CAST(CAST(-123.456 AS DOUBLE) AS STRING)")
testFoldConst("SELECT CAST(CAST(0.001 AS DOUBLE) AS STRING)")
testFoldConst("SELECT CAST(CAST(-0.001 AS DOUBLE) AS STRING)")
- testFoldConst("SELECT CAST(CAST(1e+10 AS DOUBLE) AS STRING)")
- testFoldConst("SELECT CAST(CAST(1e-10 AS DOUBLE) AS STRING)")
- testFoldConst("SELECT CAST(CAST(-1e+10 AS DOUBLE) AS STRING)")
- testFoldConst("SELECT CAST(CAST(-1e-10 AS DOUBLE) AS STRING)")
- testFoldConst("SELECT CAST(CAST(123456789.123456789 AS DOUBLE) AS STRING)")
- testFoldConst("SELECT CAST(CAST(-123456789.123456789 AS DOUBLE) AS
STRING)")
+// testFoldConst("SELECT CAST(CAST(1e+10 AS DOUBLE) AS STRING)")
Review Comment:
add comment to explain why exclude these test cases
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
