HappenLee commented on code in PR #49483:
URL: https://github.com/apache/doris/pull/49483#discussion_r2017921622
##########
be/src/vec/runtime/time_value.h:
##########
@@ -35,10 +35,20 @@ class TimeValue {
constexpr static int64_t ONE_HOUR_MICROSECONDS = 60 *
ONE_MINUTE_MICROSECONDS;
constexpr static int64_t ONE_MINUTE_SECONDS = 60;
constexpr static int64_t ONE_HOUR_SECONDS = 60 * ONE_MINUTE_SECONDS;
+ constexpr static uint32_t MICROs_SCALE = 6;
Review Comment:
why s is not lower case ？
##########
be/src/vec/runtime/time_value.h:
##########
@@ -35,10 +35,20 @@ class TimeValue {
constexpr static int64_t ONE_HOUR_MICROSECONDS = 60 *
ONE_MINUTE_MICROSECONDS;
constexpr static int64_t ONE_MINUTE_SECONDS = 60;
constexpr static int64_t ONE_HOUR_SECONDS = 60 * ONE_MINUTE_SECONDS;
+ constexpr static uint32_t MICROs_SCALE = 6;
Review Comment:
why `s` is not lower case ？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
