Copilot commented on code in PR #49542:
URL: https://github.com/apache/doris/pull/49542#discussion_r2015382205
##########
fe/fe-core/src/main/java/org/apache/doris/catalog/TableProperty.java:
##########
@@ -693,6 +693,9 @@ public void setRowStoreColumns(List<String>
rowStoreColumns) {
modifyTableProperties(PropertyAnalyzer.PROPERTIES_ROW_STORE_COLUMNS,
Joiner.on(",").join(rowStoreColumns));
buildRowStoreColumns();
+ } else {
+ // clear row store columns
+ this.rowStoreColumns = null;
Review Comment:
[nitpick] Clearing rowStoreColumns in setRowStoreColumns without updating
the underlying properties map may lead to inconsistencies in later reads.
Consider also clearing or updating the property key value for full consistency.
```suggestion
this.rowStoreColumns = null;
properties.remove(PropertyAnalyzer.PROPERTIES_ROW_STORE_COLUMNS);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
