TangSiyang2001 commented on code in PR #49452:
URL: https://github.com/apache/doris/pull/49452#discussion_r2013955899
##########
fe/fe-core/src/main/java/org/apache/doris/catalog/ColumnType.java:
##########
@@ -196,7 +197,10 @@ public static void checkForTypeLengthChange(Type src, Type
dst) throws DdlExcept
// return true if the checkType and other are both char-type otherwise
return false,
// which used in checkSupportSchemaChangeForComplexType
private static boolean checkSupportSchemaChangeForCharType(Type checkType,
Type other) throws DdlException {
- if (checkType.isStringType() && other.isStringType()) {
+ if (checkType.getPrimitiveType() == PrimitiveType.VARCHAR
Review Comment:
Cuz adding ut here does limitted help, do not modifiy in this fix PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
